libnvdimm/security: fix a typo
authorJane Chu <jane.chu@oracle.com>
Mon, 3 Aug 2020 22:41:37 +0000 (16:41 -0600)
committerVishal Verma <vishal.l.verma@intel.com>
Tue, 4 Aug 2020 00:54:13 +0000 (18:54 -0600)
commit d78c620a2e82 ("libnvdimm/security: Introduce a 'frozen' attribute")
introduced a typo, causing a 'nvdimm->sec.flags' update being overwritten
by the subsequent update meant for 'nvdimm->sec.ext_flags'.

Link: https://lore.kernel.org/r/1596494499-9852-1-git-send-email-jane.chu@oracle.com
Fixes: d78c620a2e82 ("libnvdimm/security: Introduce a 'frozen' attribute")
Cc: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jane Chu <jane.chu@oracle.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
drivers/nvdimm/security.c

index 89b85970912dbe076ae37cbc2ce56bce570f0457..acfd211c01b9c5094cd0616c8550e64fb37e4211 100644 (file)
@@ -457,7 +457,7 @@ void __nvdimm_security_overwrite_query(struct nvdimm *nvdimm)
        clear_bit(NDD_WORK_PENDING, &nvdimm->flags);
        put_device(&nvdimm->dev);
        nvdimm->sec.flags = nvdimm_security_flags(nvdimm, NVDIMM_USER);
-       nvdimm->sec.flags = nvdimm_security_flags(nvdimm, NVDIMM_MASTER);
+       nvdimm->sec.ext_flags = nvdimm_security_flags(nvdimm, NVDIMM_MASTER);
 }
 
 void nvdimm_security_overwrite_query(struct work_struct *work)