spi: s3c64xx: correct dma_chan pointer initialization
authorChanho Park <chanho61.park@samsung.com>
Mon, 8 Aug 2022 00:48:51 +0000 (09:48 +0900)
committerMark Brown <broonie@kernel.org>
Mon, 15 Aug 2022 11:18:40 +0000 (12:18 +0100)
Use NULL for dma channel pointer initialization instead of plain integer.

sparse warnings: (new ones prefixed by >>)
>> drivers/spi/spi-s3c64xx.c:387:34: sparse: sparse: Using plain integer as NULL pointer
   drivers/spi/spi-s3c64xx.c:388:34: sparse: sparse: Using plain integer as NULL pointer

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 82295bc0d192 ("spi: s3c64xx: move dma_release_channel to unprepare")
Fixes: f52b03c70744 ("spi: s3c64xx: requests spi-dma channel only during data transfer")
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
Reviewed-by: Andi Shyti <andi@etezian.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220808004851.25122-1-chanho61.park@samsung.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-s3c64xx.c

index 7f346866614abbd48ba430543da349e7ab2bb7ac..651c35dd91244c8f59aa55f8e68a0f1044c5c1e4 100644 (file)
@@ -389,8 +389,8 @@ static int s3c64xx_spi_unprepare_transfer(struct spi_master *spi)
        if (sdd->rx_dma.ch && sdd->tx_dma.ch) {
                dma_release_channel(sdd->rx_dma.ch);
                dma_release_channel(sdd->tx_dma.ch);
-               sdd->rx_dma.ch = 0;
-               sdd->tx_dma.ch = 0;
+               sdd->rx_dma.ch = NULL;
+               sdd->tx_dma.ch = NULL;
        }
 
        return 0;