iio: imu: inv_mpu6050: fix frequency setting when chip is off
authorJean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Mon, 19 Feb 2024 15:47:41 +0000 (15:47 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 25 Feb 2024 11:42:12 +0000 (11:42 +0000)
Track correctly FIFO state and apply ODR change before starting
the chip. Without the fix, you cannot change ODR more than 1 time
when data buffering is off. This restriction on a single pending ODR
change should only apply when the FIFO is on.

Fixes: 111e1abd0045 ("iio: imu: inv_mpu6050: use the common inv_sensors timestamp module")
Cc: stable@vger.kernel.org
Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Link: https://lore.kernel.org/r/20240219154741.90601-1-inv.git-commit@tdk.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c

index 676704f9151fcb4eb111cdd89d486a48fab91f28..e6e6e94452a32801ff7427112b33f0a4bb923d2f 100644 (file)
@@ -111,6 +111,7 @@ int inv_mpu6050_prepare_fifo(struct inv_mpu6050_state *st, bool enable)
        if (enable) {
                /* reset timestamping */
                inv_sensors_timestamp_reset(&st->timestamp);
+               inv_sensors_timestamp_apply_odr(&st->timestamp, 0, 0, 0);
                /* reset FIFO */
                d = st->chip_config.user_ctrl | INV_MPU6050_BIT_FIFO_RST;
                ret = regmap_write(st->map, st->reg->user_ctrl, d);
@@ -184,6 +185,10 @@ static int inv_mpu6050_set_enable(struct iio_dev *indio_dev, bool enable)
                if (result)
                        goto error_power_off;
        } else {
+               st->chip_config.gyro_fifo_enable = 0;
+               st->chip_config.accl_fifo_enable = 0;
+               st->chip_config.temp_fifo_enable = 0;
+               st->chip_config.magn_fifo_enable = 0;
                result = inv_mpu6050_prepare_fifo(st, false);
                if (result)
                        goto error_power_off;