RISC-V: Fix a PMP check with the correct access size
authorHesham Almatary <Hesham.Almatary@cl.cam.ac.uk>
Thu, 30 May 2019 13:51:35 +0000 (14:51 +0100)
committerPalmer Dabbelt <palmer@sifive.com>
Mon, 24 Jun 2019 06:44:42 +0000 (23:44 -0700)
The PMP check should be of the memory access size rather
than TARGET_PAGE_SIZE.

Signed-off-by: Hesham Almatary <Hesham.Almatary@cl.cam.ac.uk>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
target/riscv/cpu_helper.c

index 66be83210f11963944e50c4f7745f8a619e9f529..e1b079e69c603491623de89713ca4c6abf39518e 100644 (file)
@@ -452,8 +452,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
 
     if (riscv_feature(env, RISCV_FEATURE_PMP) &&
         (ret == TRANSLATE_SUCCESS) &&
-        !pmp_hart_has_privs(env, pa, TARGET_PAGE_SIZE, 1 << access_type,
-        mode)) {
+        !pmp_hart_has_privs(env, pa, size, 1 << access_type, mode)) {
         ret = TRANSLATE_PMP_FAIL;
     }
     if (ret == TRANSLATE_PMP_FAIL) {