drm/display/dp_mst: Fix down/up message handling after sink disconnect
authorImre Deak <imre.deak@intel.com>
Wed, 14 Dec 2022 18:42:56 +0000 (20:42 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 12:57:39 +0000 (13:57 +0100)
commit 1d082618bbf3b6755b8cc68c0a8122af2842d593 upstream.

If the sink gets disconnected during receiving a multi-packet DP MST AUX
down-reply/up-request sideband message, the state keeping track of which
packets have been received already is not reset. This results in a failed
sanity check for the subsequent message packet received after a sink is
reconnected (due to the pending message not yet completed with an
end-of-message-transfer packet), indicated by the

"sideband msg set header failed"

error.

Fix the above by resetting the up/down message reception state after a
disconnect event.

Cc: Lyude Paul <lyude@redhat.com>
Cc: <stable@vger.kernel.org> # v3.17+
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221214184258.2869417-1-imre.deak@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/drm_dp_mst_topology.c

index 0d915fe8b6e43ad94989f65d48f206e04ca4e027..c1f7274914e3cfe4b8b09e0da8d2fe8e2920ff2f 100644 (file)
@@ -3781,6 +3781,9 @@ int drm_dp_mst_topology_mgr_set_mst(struct drm_dp_mst_topology_mgr *mgr, bool ms
                set_bit(0, &mgr->payload_mask);
                mgr->vcpi_mask = 0;
                mgr->payload_id_table_cleared = false;
+
+               memset(&mgr->down_rep_recv, 0, sizeof(mgr->down_rep_recv));
+               memset(&mgr->up_req_recv, 0, sizeof(mgr->up_req_recv));
        }
 
 out_unlock: