drm/i915/gvt: do not check len & max_len for lri
authorYan Zhao <yan.y.zhao@intel.com>
Wed, 18 Mar 2020 05:48:26 +0000 (13:48 +0800)
committerZhenyu Wang <zhenyuw@linux.intel.com>
Wed, 18 Mar 2020 05:48:26 +0000 (13:48 +0800)
lri ususally of variable len and far exceeding 127 dwords.

Fixes: 00a33be40634 ("drm/i915/gvt: Add valid length check for MI variable commands")
Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20200304095121.21609-1-yan.y.zhao@intel.com
drivers/gpu/drm/i915/gvt/cmd_parser.c

index bb204cfb9006fc7e94656f1c51e7be21a3bffd57..a3cc080a46c694d4c053ac49dd70fdc7616dd0df 100644 (file)
@@ -968,18 +968,6 @@ static int cmd_handler_lri(struct parser_exec_state *s)
 {
        int i, ret = 0;
        int cmd_len = cmd_length(s);
-       u32 valid_len = CMD_LEN(1);
-
-       /*
-        * Official intel docs are somewhat sloppy , check the definition of
-        * MI_LOAD_REGISTER_IMM.
-        */
-       #define MAX_VALID_LEN 127
-       if ((cmd_len < valid_len) || (cmd_len > MAX_VALID_LEN)) {
-               gvt_err("len is not valid:  len=%u  valid_len=%u\n",
-                       cmd_len, valid_len);
-               return -EFAULT;
-       }
 
        for (i = 1; i < cmd_len; i += 2) {
                if (IS_BROADWELL(s->engine->i915) && s->engine->id != RCS0) {