scsi: qla2xxx: Use true, false for ha->fw_dumped

Fix the following coccicheck warning:

drivers/scsi/qla2xxx/qla_tmpl.c:1120:2-20: WARNING: Assignment of 0/1 to
bool variable

Link: https://lore.kernel.org/r/20200430121800.15323-1-yanaijie@huawei.com
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
index e83e44ef7083f55a2f0eb7e80275aa5b5cedff35..4ee1a75e54ad95f07abdf8b7b387347b141ea476 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_attr.c
+++ b/drivers/scsi/qla2xxx/qla_attr.c
@@ -84,7 +84,7 @@ qla2x00_sysfs_write_fw_dump(struct file *filp, struct kobject *kobj,
                        qla82xx_md_prep(vha);
                }
                ha->fw_dump_reading = 0;
-               ha->fw_dumped = 0;
+               ha->fw_dumped = false;
                break;
        case 1:
                if (ha->fw_dumped && !ha->fw_dump_reading) {

diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c
index 8b7d0e476773b7e9fb0fb4ff7c50abac4232c884..1206f7c1ce6a8191ac82d0c36e905c1afd3ba0f2 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_dbg.c
+++ b/drivers/scsi/qla2xxx/qla_dbg.c
@@ -706,12 +706,12 @@ qla2xxx_dump_post_process(scsi_qla_host_t *vha, int rval)
                ql_log(ql_log_warn, vha, 0xd000,
                    "Failed to dump firmware (%x), dump status flags (0x%lx).\n",
                    rval, ha->fw_dump_cap_flags);
-               ha->fw_dumped = 0;
+               ha->fw_dumped = false;
        } else {
                ql_log(ql_log_info, vha, 0xd001,
                    "Firmware dump saved to temp buffer (%ld/%p), dump status flags (0x%lx).\n",
                    vha->host_no, ha->fw_dump, ha->fw_dump_cap_flags);
-               ha->fw_dumped = 1;
+               ha->fw_dumped = true;
                qla2x00_post_uevent_work(vha, QLA_UEVENT_CODE_FW_DUMP);
        }
 }

diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c
index 185c5f34d4c14757283a26395aadaf5ecb7131e3..d2037253e2d796d891d19b2ce2abdc1e069c014c 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_nx.c
+++ b/drivers/scsi/qla2xxx/qla_nx.c
@@ -4177,7 +4177,7 @@ qla82xx_md_collect(scsi_qla_host_t *vha)
                goto md_failed;
        }
 
-       ha->fw_dumped = 0;
+       ha->fw_dumped = false;
 
        if (!ha->md_tmplt_hdr || !ha->md_dump) {
                ql_log(ql_log_warn, vha, 0xb038,
@@ -4357,7 +4357,7 @@ skip_nxt_entry:
        ql_log(ql_log_info, vha, 0xb044,
            "Firmware dump saved to temp buffer (%ld/%p %ld/%p).\n",
            vha->host_no, ha->md_tmplt_hdr, vha->host_no, ha->md_dump);
-       ha->fw_dumped = 1;
+       ha->fw_dumped = true;
        qla2x00_post_uevent_work(vha, QLA_UEVENT_CODE_FW_DUMP);
 
 md_failed:

diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c
index c056f466f1f4a829d35a2f160b5720b1edb24c51..b5c3e56edabad83a221f0bdc369fd2a66c4697f7 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_nx2.c
+++ b/drivers/scsi/qla2xxx/qla_nx2.c
@@ -1441,7 +1441,7 @@ qla8044_device_bootstrap(struct scsi_qla_host *vha)
        if (idc_ctrl & GRACEFUL_RESET_BIT1) {
                qla8044_wr_reg(ha, QLA8044_IDC_DRV_CTRL,
                    (idc_ctrl & ~GRACEFUL_RESET_BIT1));
-               ha->fw_dumped = 0;
+               ha->fw_dumped = false;
        }
 
 dev_ready:
@@ -3249,7 +3249,7 @@ qla8044_collect_md_data(struct scsi_qla_host *vha)
                goto md_failed;
        }
 
-       ha->fw_dumped = 0;
+       ha->fw_dumped = false;
 
        if (!ha->md_tmplt_hdr || !ha->md_dump) {
                ql_log(ql_log_warn, vha, 0xb10e,
@@ -3470,7 +3470,7 @@ skip_nxt_entry:
        ql_log(ql_log_info, vha, 0xb110,
            "Firmware dump saved to temp buffer (%ld/%p %ld/%p).\n",
            vha->host_no, ha->md_tmplt_hdr, vha->host_no, ha->md_dump);
-       ha->fw_dumped = 1;
+       ha->fw_dumped = true;
        qla2x00_post_uevent_work(vha, QLA_UEVENT_CODE_FW_DUMP);
 
 
@@ -3487,7 +3487,7 @@ qla8044_get_minidump(struct scsi_qla_host *vha)
        struct qla_hw_data *ha = vha->hw;
 
        if (!qla8044_collect_md_data(vha)) {
-               ha->fw_dumped = 1;
+               ha->fw_dumped = true;
                ha->prev_minidump_failed = 0;
        } else {
                ql_log(ql_log_fatal, vha, 0xb0db,

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index f51ade7cfcc8215cf036ee0557dcdec23381d4df..382e1f977d01b517a06272091324ededa7b76f6c 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4622,7 +4622,7 @@ qla2x00_free_fw_dump(struct qla_hw_data *ha)
        ha->flags.fce_enabled = 0;
        ha->eft = NULL;
        ha->eft_dma = 0;
-       ha->fw_dumped = 0;
+       ha->fw_dumped = false;
        ha->fw_dump_cap_flags = 0;
        ha->fw_dump_reading = 0;
        ha->fw_dump = NULL;

diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
index dc97f2fbeafebe13a510d5628afbc3c627d7e0b2..281973b317a813990738c94f12fb5cf04803c458 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_tmpl.c
+++ b/drivers/scsi/qla2xxx/qla_tmpl.c
@@ -1117,7 +1117,7 @@ qla27xx_fwdump(scsi_qla_host_t *vha, int hardware_locked)
                }
 
                vha->hw->fw_dump_len = len;
-               vha->hw->fw_dumped = 1;
+               vha->hw->fw_dumped = true;
 
                ql_log(ql_log_warn, vha, 0xd015,
                    "-> Firmware dump saved to buffer (%lu/%p) <%lx>\n",