cxl/trace: Remove unnecessary memcpy's
authorIra Weiny <ira.weiny@intel.com>
Wed, 31 Jan 2024 23:55:39 +0000 (15:55 -0800)
committerArd Biesheuvel <ardb@kernel.org>
Sat, 3 Feb 2024 17:31:17 +0000 (18:31 +0100)
CPER events don't have UUIDs.  Therefore UUIDs were removed from the
records passed to trace events and replaced with hard coded values.

As pointed out by Jonathan, the new defines for the UUIDs present a more
efficient way to assign UUID in trace records.[1]

Replace memcpy's with the use of static data.

[1] https://lore.kernel.org/all/20240108132325.00000e9c@Huawei.com/

Suggested-by: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
drivers/cxl/core/trace.h

index 89445435303aac4d043c964a0ada866548889917..bdf117a33744be2db0468e869226ac8d45ef7a16 100644 (file)
@@ -338,7 +338,7 @@ TRACE_EVENT(cxl_general_media,
 
        TP_fast_assign(
                CXL_EVT_TP_fast_assign(cxlmd, log, rec->hdr);
-               memcpy(&__entry->hdr_uuid, &CXL_EVENT_GEN_MEDIA_UUID, sizeof(uuid_t));
+               __entry->hdr_uuid = CXL_EVENT_GEN_MEDIA_UUID;
 
                /* General Media */
                __entry->dpa = le64_to_cpu(rec->phys_addr);
@@ -425,7 +425,7 @@ TRACE_EVENT(cxl_dram,
 
        TP_fast_assign(
                CXL_EVT_TP_fast_assign(cxlmd, log, rec->hdr);
-               memcpy(&__entry->hdr_uuid, &CXL_EVENT_DRAM_UUID, sizeof(uuid_t));
+               __entry->hdr_uuid = CXL_EVENT_DRAM_UUID;
 
                /* DRAM */
                __entry->dpa = le64_to_cpu(rec->phys_addr);
@@ -573,7 +573,7 @@ TRACE_EVENT(cxl_memory_module,
 
        TP_fast_assign(
                CXL_EVT_TP_fast_assign(cxlmd, log, rec->hdr);
-               memcpy(&__entry->hdr_uuid, &CXL_EVENT_MEM_MODULE_UUID, sizeof(uuid_t));
+               __entry->hdr_uuid = CXL_EVENT_MEM_MODULE_UUID;
 
                /* Memory Module Event */
                __entry->event_type = rec->event_type;