xfs: do not need to check return value of xlog_kvmalloc()
authorZhiqiang Liu <liuzhiqiang26@huawei.com>
Sun, 18 Sep 2022 20:55:14 +0000 (06:55 +1000)
committerDave Chinner <david@fromorbit.com>
Sun, 18 Sep 2022 20:55:14 +0000 (06:55 +1000)
In xfs_attri_log_nameval_alloc(), xlog_kvmalloc() is called
to alloc memory, which will always return
successfully, so we donot need to check return value.

Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_attr_item.c

index 5077a7ad56460f78cffb578f3bddc381e2da8cd3..cf5ce607dc051fe15bfb211cff03d0345a73ef04 100644 (file)
@@ -86,8 +86,6 @@ xfs_attri_log_nameval_alloc(
         */
        nv = xlog_kvmalloc(sizeof(struct xfs_attri_log_nameval) +
                                        name_len + value_len);
-       if (!nv)
-               return nv;
 
        nv->name.i_addr = nv + 1;
        nv->name.i_len = name_len;
@@ -441,8 +439,6 @@ xfs_attr_create_intent(
                attr->xattri_nameval = xfs_attri_log_nameval_alloc(args->name,
                                args->namelen, args->value, args->valuelen);
        }
-       if (!attr->xattri_nameval)
-               return ERR_PTR(-ENOMEM);
 
        attrip = xfs_attri_init(mp, attr->xattri_nameval);
        xfs_trans_add_item(tp, &attrip->attri_item);
@@ -762,8 +758,6 @@ xlog_recover_attri_commit_pass2(
        nv = xfs_attri_log_nameval_alloc(attr_name,
                        attri_formatp->alfi_name_len, attr_value,
                        attri_formatp->alfi_value_len);
-       if (!nv)
-               return -ENOMEM;
 
        attrip = xfs_attri_init(mp, nv);
        error = xfs_attri_copy_format(&item->ri_buf[0], &attrip->attri_format);