block: fix a warning when blkdev.h is included for !CONFIG_BLOCK builds
authorChristoph Hellwig <hch@lst.de>
Thu, 28 May 2020 13:41:23 +0000 (15:41 +0200)
committerJens Axboe <axboe@kernel.dk>
Thu, 28 May 2020 14:47:13 +0000 (08:47 -0600)
disk_start_io_acct and disk_end_io_acct need at least a struct gendisk
forward declaration, but for weird historic reasons much of blkdev.h
is stubbed out for CONFIG_BLOCK=n.  Fix this by stubbing more out for
now, but eventually this header will need a massive cleanup.

Fixes: 956d510ee78 ("block: add disk/bio-based accounting helpers")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/linux/blkdev.h

index 6f7ff0fa8fcf81a3c2df14c04cdba4d60bdd997f..8fd900998b4e2e7cca1a44a47e3ceebb496331d5 100644 (file)
@@ -1892,12 +1892,12 @@ static inline void blk_wake_io_task(struct task_struct *waiter)
                wake_up_process(waiter);
 }
 
+#ifdef CONFIG_BLOCK
 unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
                unsigned int op);
 void disk_end_io_acct(struct gendisk *disk, unsigned int op,
                unsigned long start_time);
 
-#ifdef CONFIG_BLOCK
 /**
  * bio_start_io_acct - start I/O accounting for bio based drivers
  * @bio:       bio to start account for