USB: serial: cp210x: drop short control-transfer checks
authorJohan Hovold <johan@kernel.org>
Mon, 18 Jan 2021 11:13:29 +0000 (12:13 +0100)
committerJohan Hovold <johan@kernel.org>
Mon, 18 Jan 2021 13:24:59 +0000 (14:24 +0100)
There's no need to check for short control transfers when sending data
so remove the redundant sanity checks.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/cp210x.c

index 4f90573c0d2b294c18837505dd7f9816f5295e6c..360398665c171c1dc701f4afb721509da3fe64a9 100644 (file)
@@ -674,16 +674,13 @@ static int cp210x_write_reg_block(struct usb_serial_port *port, u8 req,
 
        kfree(dmabuf);
 
-       if (result == bufsize) {
-               result = 0;
-       } else {
+       if (result < 0) {
                dev_err(&port->dev, "failed set req 0x%x size %d status: %d\n",
                                req, bufsize, result);
-               if (result >= 0)
-                       result = -EIO;
+               return result;
        }
 
-       return result;
+       return 0;
 }
 
 /*
@@ -720,17 +717,14 @@ static int cp210x_write_vendor_block(struct usb_serial *serial, u8 type,
 
        kfree(dmabuf);
 
-       if (result == bufsize) {
-               result = 0;
-       } else {
+       if (result < 0) {
                dev_err(&serial->interface->dev,
                        "failed to set vendor val 0x%04x size %d: %d\n", val,
                        bufsize, result);
-               if (result >= 0)
-                       result = -EIO;
+               return result;
        }
 
-       return result;
+       return 0;
 }
 #endif