scsi: ufs: ufs-qcom: No need to set hs_rate after ufshcd_init_host_param()
authorCan Guo <quic_cang@quicinc.com>
Sat, 2 Dec 2023 12:36:08 +0000 (04:36 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 14 Dec 2023 03:37:20 +0000 (22:37 -0500)
In ufs_qcom_pwr_change_notify(), host_params.hs_rate has been set to
PA_HS_MODE_B by ufshcd_init_host_param(), hence remove the duplicated line
of work. Meanwhile, removed the macro UFS_QCOM_LIMIT_HS_RATE as it is only
used here.

Reviewed-by: Nitin Rawat <quic_nitirawa@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Signed-off-by: Can Guo <quic_cang@quicinc.com>
Link: https://lore.kernel.org/r/1701520577-31163-3-git-send-email-quic_cang@quicinc.com
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/host/ufs-qcom.c
drivers/ufs/host/ufs-qcom.h

index 197c5a5ab1365db1b4da76220c66dfd85e1a95fe..c21ff2cd7aa6fc432b31efa49086e4b0b6104612 100644 (file)
@@ -909,7 +909,6 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba,
        switch (status) {
        case PRE_CHANGE:
                ufshcd_init_host_params(&host_params);
-               host_params.hs_rate = UFS_QCOM_LIMIT_HS_RATE;
 
                /* This driver only supports symmetic gear setting i.e., hs_tx_gear == hs_rx_gear */
                host_params.hs_tx_gear = host_params.hs_rx_gear = ufs_qcom_get_hs_gear(hba);
index 9950a0089475fca3088c3d58551600cad3cfb538..82cd1436f42d51c0649c36d41639193eb570aea1 100644 (file)
@@ -27,8 +27,6 @@
 #define SLOW 1
 #define FAST 2
 
-#define UFS_QCOM_LIMIT_HS_RATE         PA_HS_MODE_B
-
 /* QCOM UFS host controller vendor specific registers */
 enum {
        REG_UFS_SYS1CLK_1US                 = 0xC0,