projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1633e49
)
bcachefs: Drop a faulty assertion
author
Kent Overstreet
<kent.overstreet@gmail.com>
Fri, 1 Mar 2019 20:51:57 +0000
(15:51 -0500)
committer
Kent Overstreet
<kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:08:16 +0000
(17:08 -0400)
the assertion was meant to check that bch2_journal_reclaim_fast() was
always being called, but since the atomic dec can happen outside of
j->lock the assertion itself can race
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/journal_reclaim.c
patch
|
blob
|
history
diff --git
a/fs/bcachefs/journal_reclaim.c
b/fs/bcachefs/journal_reclaim.c
index 3b5b646859cb1a4c99b524aae48955769e9f0114..431afeab42b0054079e063a8917348f77b5e8024 100644
(file)
--- a/
fs/bcachefs/journal_reclaim.c
+++ b/
fs/bcachefs/journal_reclaim.c
@@
-333,8
+333,6
@@
journal_get_next_pin(struct journal *j, u64 max_seq, u64 *seq)
spin_lock(&j->lock);
- BUG_ON(!atomic_read(&fifo_peek_front(&j->pin).count));
-
fifo_for_each_entry_ptr(pin_list, &j->pin, *seq)
if (*seq > max_seq ||
(ret = list_first_entry_or_null(&pin_list->list,