block: drop extra error propagation for bdrv_set_backing_hd
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Tue, 2 Feb 2021 12:49:47 +0000 (15:49 +0300)
committerEric Blake <eblake@redhat.com>
Mon, 8 Mar 2021 21:14:13 +0000 (15:14 -0600)
bdrv_set_backing_hd now returns status, let's use it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Message-Id: <20210202124956.63146-6-vsementsov@virtuozzo.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
block.c

diff --git a/block.c b/block.c
index a1f3cecd75525155e91da1eb7f024f31dc20d585..933ff49b10ff8200d0761a234878beafc7a4933d 100644 (file)
--- a/block.c
+++ b/block.c
@@ -2995,11 +2995,9 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options,
 
     /* Hook up the backing file link; drop our reference, bs owns the
      * backing_hd reference now */
-    bdrv_set_backing_hd(bs, backing_hd, &local_err);
+    ret = bdrv_set_backing_hd(bs, backing_hd, errp);
     bdrv_unref(backing_hd);
-    if (local_err) {
-        error_propagate(errp, local_err);
-        ret = -EINVAL;
+    if (ret < 0) {
         goto free_exit;
     }