xen/privcmd: return -ENOTTY for unimplemented IOCTLs

The code sets the default return code to -ENOSYS but then overrides this
to -EINVAL in the switch() statement's default case, which is clearly
silly.

This patch removes the override and sets the default return code to
-ENOTTY, which is the conventional return for an unimplemented ioctl.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index 6e3306f4a5250c85d7661a7145df7f8d254d5783..5e5c7aef0c9fa6538529ad0efad9c41b9074ca3d 100644 (file)
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -551,7 +551,7 @@ out_unlock:
 static long privcmd_ioctl(struct file *file,
                          unsigned int cmd, unsigned long data)
 {
-       int ret = -ENOSYS;
+       int ret = -ENOTTY;
        void __user *udata = (void __user *) data;
 
        switch (cmd) {
@@ -572,7 +572,6 @@ static long privcmd_ioctl(struct file *file,
                break;
 
        default:
-               ret = -EINVAL;
                break;
        }