ALSA: hda/tas2781: annotate calibration data endianness
authorGergo Koteles <soyer@irl.hu>
Mon, 8 Jan 2024 21:16:46 +0000 (22:16 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 9 Jan 2024 14:13:09 +0000 (15:13 +0100)
Sparse reports an endian mismatch.
The amplifier expects the calibration data as big-endian.
Use the __be32 type to express endianness better.

Fixes: c3ca4458cc2f ("ALSA: hda/tas2781: add TAS2563 support for 14ARB7")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202401072137.Oc7pQgRW-lkp@intel.com/
Signed-off-by: Gergo Koteles <soyer@irl.hu>
Link: https://lore.kernel.org/r/3852ff28ea7d5d8f2086d8dd78aeff8d1d984991.1704748435.git.soyer@irl.hu
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/tas2781_hda_i2c.c

index 4805cf0b6480826edc833ff0822d9a371d0c1af3..2dd809de62e5a4ac049a49752f447b0a8b4a3be6 100644 (file)
@@ -424,8 +424,8 @@ static const struct snd_kcontrol_new tas2781_dsp_conf_ctrl = {
 
 static void tas2563_apply_calib(struct tasdevice_priv *tas_priv)
 {
-       unsigned int data;
        int offset = 0;
+       __be32 data;
        int ret;
 
        for (int i = 0; i < tas_priv->ndev; i++) {