soc: qcom: pmic_glink: remove redundant calculation of svid

gcc with W=1 reports
drivers/soc/qcom/pmic_glink_altmode.c:223:13: error: variable ‘svid’ set but not used [-Werror=unused-but-set-variable]
  223 |         u16 svid;

From reviewing the code, the setting of alt_port->svid does the same calculation.
Both are not needed.  For debuggablity, keep the setting of local svid.

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230206135831.1794583-1-trix@redhat.com

diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c
index 71f861b8cb51c0d731cb0f745e33e40da8a3b679..4d7895bdeaf2f01f96e94bdf33c571bc03589f32 100644 (file)
--- a/drivers/soc/qcom/pmic_glink_altmode.c
+++ b/drivers/soc/qcom/pmic_glink_altmode.c
@@ -248,7 +248,7 @@ static void pmic_glink_altmode_sc8180xp_notify(struct pmic_glink_altmode *altmod
 
        alt_port = &altmode->ports[port];
        alt_port->orientation = pmic_glink_altmode_orientation(orientation);
-       alt_port->svid = mux == 2 ? USB_TYPEC_DP_SID : 0;
+       alt_port->svid = svid;
        alt_port->mode = mode;
        alt_port->hpd_state = hpd_state;
        alt_port->hpd_irq = hpd_irq;