net/9p: Fix a potential socket leak in p9_socket_open

Both p9_fd_create_tcp() and p9_fd_create_unix() will call
p9_socket_open(). If the creation of p9_trans_fd fails,
p9_fd_create_tcp() and p9_fd_create_unix() will return an
error directly instead of releasing the cscoket, which will
result in a socket leak.

This patch adds sock_release() to fix the leak issue.

Fixes: 6b18662e239a ("9p connect fixes")
Signed-off-by: Wang Hai <wanghai38@huawei.com>
ACKed-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index 56a1867687501a21d85dfd84105ef8f76b9c4d1d..f834726d21ea9bc11d3d3608cc6db4b1bbc9732a 100644 (file)
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -860,8 +860,10 @@ static int p9_socket_open(struct p9_client *client, struct socket *csocket)
        struct file *file;
 
        p = kzalloc(sizeof(struct p9_trans_fd), GFP_KERNEL);
-       if (!p)
+       if (!p) {
+               sock_release(csocket);
                return -ENOMEM;
+       }
 
        csocket->sk->sk_allocation = GFP_NOIO;
        file = sock_alloc_file(csocket, 0, NULL);