mt76: mt7615: move mcu bss upload before creating the sta
authorLorenzo Bianconi <lorenzo@kernel.org>
Wed, 22 Apr 2020 11:07:44 +0000 (13:07 +0200)
committerFelix Fietkau <nbd@nbd.name>
Tue, 12 May 2020 17:52:33 +0000 (19:52 +0200)
Run mt7615_mcu_add_bss_info routine before mt7615_mcu_sta_add since
the firmware requires the bss is created before the relative sta

Tested-by: Sean Wang <sean.wang@mediatek.com>
Suggested-by: YF Luo <yf.luo@mediatek.com>
Suggested-by: Lucy Hsu <lucy.hsu@mediatek.com>
Co-developed-by: Soul Huang <soul.huang@mediatek.com>
Signed-off-by: Soul Huang <soul.huang@mediatek.com>
Co-developed-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7615/main.c

index 8f8ad632d6bae76a7f6ed40d24c7762553754906..3c35b8d0489c158f980578b0671d61a66e21d2c8 100644 (file)
@@ -491,9 +491,6 @@ static void mt7615_bss_info_changed(struct ieee80211_hw *hw,
 
        mutex_lock(&dev->mt76.mutex);
 
-       if (changed & BSS_CHANGED_ASSOC)
-               mt7615_mcu_add_bss_info(phy, vif, info->assoc);
-
        if (changed & BSS_CHANGED_ERP_SLOT) {
                int slottime = info->use_short_slot ? 9 : 20;
 
@@ -545,9 +542,14 @@ int mt7615_mac_sta_add(struct mt76_dev *mdev, struct ieee80211_vif *vif,
        msta->wcid.idx = idx;
        msta->wcid.ext_phy = mvif->band_idx;
 
+       if (vif->type == NL80211_IFTYPE_STATION) {
+               struct mt7615_phy *phy;
+
+               phy = mvif->band_idx ? mt7615_ext_phy(dev) : &dev->phy;
+               mt7615_mcu_add_bss_info(phy, vif, true);
+       }
        mt7615_mac_wtbl_update(dev, idx,
                               MT_WTBL_UPDATE_ADM_COUNT_CLEAR);
-
        mt7615_mcu_sta_add(dev, vif, sta, true);
 
        return 0;
@@ -563,6 +565,13 @@ void mt7615_mac_sta_remove(struct mt76_dev *mdev, struct ieee80211_vif *vif,
        mt7615_mcu_sta_add(dev, vif, sta, false);
        mt7615_mac_wtbl_update(dev, msta->wcid.idx,
                               MT_WTBL_UPDATE_ADM_COUNT_CLEAR);
+       if (vif->type == NL80211_IFTYPE_STATION) {
+               struct mt7615_vif *mvif = (struct mt7615_vif *)vif->drv_priv;
+               struct mt7615_phy *phy;
+
+               phy = mvif->band_idx ? mt7615_ext_phy(dev) : &dev->phy;
+               mt7615_mcu_add_bss_info(phy, vif, false);
+       }
 
        spin_lock_bh(&dev->sta_poll_lock);
        if (!list_empty(&msta->poll_list))