gpio: merrifield: Use dev_err_probe()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 16 Jan 2023 14:44:46 +0000 (15:44 +0100)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 6 Mar 2023 15:10:46 +0000 (17:10 +0200)
Improve error handling in the probe() function with dev_err_probe().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/gpio/gpio-merrifield.c

index 5c0b460fcd9053a00259930c3cfd948f64461703..c64057343954666dfea8a81a908bfaf16dbdca87 100644 (file)
@@ -78,10 +78,8 @@ static int mrfld_gpio_probe(struct pci_dev *pdev, const struct pci_device_id *id
                return retval;
 
        retval = pcim_iomap_regions(pdev, BIT(1) | BIT(0), pci_name(pdev));
-       if (retval) {
-               dev_err(&pdev->dev, "I/O memory mapping error\n");
-               return retval;
-       }
+       if (retval)
+               return dev_err_probe(dev, retval, "I/O memory mapping error\n");
 
        base = pcim_iomap_table(pdev)[1];