arm: ptrace: user_regset_copyin_ignore() always returns 0
authorSergey Shtylyov <s.shtylyov@omp.ru>
Fri, 14 Oct 2022 21:22:24 +0000 (00:22 +0300)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 15 Nov 2022 22:30:39 +0000 (14:30 -0800)
user_regset_copyin_ignore() always returns 0, so checking its result seems
pointless -- don't do this anymore...

Link: https://lkml.kernel.org/r/20221014212235.10770-3-s.shtylyov@omp.ru
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Brian Cain <bcain@quicinc.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: David S. Miller <davem@davemloft.net>
Cc: Dinh Nguyen <dinguyen@kernel.org>
Cc: Helge Deller <deller@gmx.de>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jonas Bonn <jonas@southpole.se>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Rich Felker <dalias@libc.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Stafford Horne <shorne@gmail.com>
Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Will Deacon <will@kernel.org>
Cc: Yoshinori Sato <ysato@users.osdn.me>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
arch/arm/kernel/ptrace.c

index bfe88c6e60d587c6566748ee41f7e2b024c4787a..2d8e2516906b6b4a2a1898ccc179d340b697cac5 100644 (file)
@@ -651,11 +651,9 @@ static int vfp_set(struct task_struct *target,
        if (ret)
                return ret;
 
-       ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf,
-                               user_fpregs_offset + sizeof(new_vfp.fpregs),
-                               user_fpscr_offset);
-       if (ret)
-               return ret;
+       user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf,
+                                 user_fpregs_offset + sizeof(new_vfp.fpregs),
+                                 user_fpscr_offset);
 
        ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
                                 &new_vfp.fpscr,