drm/amd/display: Fix Replay Desync Error IRQ handler
authorDennis Chan <dennis.chan@amd.com>
Fri, 1 Dec 2023 13:25:19 +0000 (06:25 -0700)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 6 Dec 2023 20:22:34 +0000 (15:22 -0500)
In previous case, Replay didn't identify the IRQ type, This commit fixes
the issues for the interrupt.

Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Reviewed-by: Robin Chen <robin.chen@amd.com>
Acked-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Dennis Chan <dennis.chan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_irq_handler.c

index ae271c830c9aaf0fce823a53d96f689eceb7e898..ba69874be5a49184ed2fb98eddabb401620d473b 100644 (file)
@@ -190,9 +190,6 @@ static void handle_hpd_irq_replay_sink(struct dc_link *link)
        /*AMD Replay version reuse DP_PSR_ERROR_STATUS for REPLAY_ERROR status.*/
        union psr_error_status replay_error_status;
 
-       if (link->replay_settings.config.force_disable_desync_error_check)
-               return;
-
        if (!link->replay_settings.replay_feature_enabled)
                return;
 
@@ -210,9 +207,6 @@ static void handle_hpd_irq_replay_sink(struct dc_link *link)
                &replay_error_status.raw,
                sizeof(replay_error_status.raw));
 
-       if (replay_configuration.bits.DESYNC_ERROR_STATUS)
-               link->replay_settings.config.received_desync_error_hpd = 1;
-
        link->replay_settings.config.replay_error_status.bits.LINK_CRC_ERROR =
                replay_error_status.bits.LINK_CRC_ERROR;
        link->replay_settings.config.replay_error_status.bits.DESYNC_ERROR =
@@ -225,6 +219,12 @@ static void handle_hpd_irq_replay_sink(struct dc_link *link)
                link->replay_settings.config.replay_error_status.bits.STATE_TRANSITION_ERROR) {
                bool allow_active;
 
+               if (link->replay_settings.config.replay_error_status.bits.DESYNC_ERROR)
+                       link->replay_settings.config.received_desync_error_hpd = 1;
+
+               if (link->replay_settings.config.force_disable_desync_error_check)
+                       return;
+
                /* Acknowledge and clear configuration bits */
                dm_helpers_dp_write_dpcd(
                        link->ctx,