ASoC: wm_adsp: Correct wm_coeff_tlv_get handling
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Sat, 26 Jun 2021 15:59:39 +0000 (16:59 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 28 Jun 2021 16:47:39 +0000 (17:47 +0100)
When wm_coeff_tlv_get was updated it was accidentally switch to the _raw
version of the helper causing it to ignore the current DSP state it
should be checking. Switch the code back to the correct helper so that
users can't read the controls when they arn't available.

Fixes: 73ecf1a673d3 ("ASoC: wm_adsp: Correct cache handling of new kernel control API")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210626155941.12251-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm_adsp.c

index 37aa020f23f631c3635c0a925de1124db07b2177..59d876d36cfd8d8615741c37e81f1f1edd882d5d 100644 (file)
@@ -1213,7 +1213,7 @@ static int wm_coeff_tlv_get(struct snd_kcontrol *kctl,
 
        mutex_lock(&ctl->dsp->pwr_lock);
 
-       ret = wm_coeff_read_ctrl_raw(ctl, ctl->cache, size);
+       ret = wm_coeff_read_ctrl(ctl, ctl->cache, size);
 
        if (!ret && copy_to_user(bytes, ctl->cache, size))
                ret = -EFAULT;