Revert "usb: gadget: uvc: cleanup request when not in correct state"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Oct 2023 08:51:04 +0000 (10:51 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Oct 2023 08:52:39 +0000 (10:52 +0200)
This reverts commit 52a39f2cf62bb5430ad1f54cd522dbfdab1d71ba.

Based on review comments, it was applied too soon and needs more work.

Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/20231005081716.GA13853@pendragon.ideasonboard.com
Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/uvc_video.c

index c48c904f500fff8cab29f9bebecc26537cb2b3e9..4b68a3a9815d7339621b3b226271710049a2ae62 100644 (file)
@@ -256,12 +256,6 @@ uvc_video_complete(struct usb_ep *ep, struct usb_request *req)
        struct uvc_device *uvc = video->uvc;
        unsigned long flags;
 
-       if (uvc->state == UVC_STATE_CONNECTED) {
-               usb_ep_free_request(video->ep, ureq->req);
-               ureq->req = NULL;
-               return;
-       }
-
        switch (req->status) {
        case 0:
                break;