iio:dac:ad3552r: Fix an IS_ERR() vs NULL check
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 4 Apr 2022 11:42:44 +0000 (14:42 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 10 Apr 2022 16:57:40 +0000 (17:57 +0100)
The fwnode_get_named_child_node() function does not return error
pointers.  It returns NULL.  Update the check accordingly.

Fixes: 8f2b54824b28 ("drivers:iio:dac: Add AD3552R driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220404114244.GA19201@kili
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ad3552r.c

index e0a93b27e0e81431df23d9d005bd27aaa37f810b..d5ea1a1be1226bf57c231bc9a8f3634d005028f6 100644 (file)
@@ -809,10 +809,10 @@ static int ad3552r_configure_custom_gain(struct ad3552r_desc *dac,
 
        gain_child = fwnode_get_named_child_node(child,
                                                 "custom-output-range-config");
-       if (IS_ERR(gain_child)) {
+       if (!gain_child) {
                dev_err(dev,
                        "mandatory custom-output-range-config property missing\n");
-               return PTR_ERR(gain_child);
+               return -EINVAL;
        }
 
        dac->ch_data[ch].range_override = 1;