staging: rtl8723bs: remove DBG_COUNTER calls from os_dep/recv_linux.c
authorPhillip Potter <phil@philpotter.co.uk>
Mon, 15 Feb 2021 23:34:35 +0000 (23:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Mar 2021 08:25:23 +0000 (09:25 +0100)
Remove all DBG_COUNTER macro calls from os_dep/recv_linux.c, as the
corresponding variables are only ever written to and not used. This
makes the code cleaner, and is necessary prior to removing the
DBG_COUNTER definition itself.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210215233440.80617-2-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/os_dep/recv_linux.c

index ac35277fbacd0fc1bc2c6a81d548cd6e555c5d7b..f52802f24466a715c6d35b65b26a4ffaf59dc972 100644 (file)
@@ -124,18 +124,14 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt
 
                                        _rtw_xmit_entry(pkt, pnetdev);
 
-                                       if (bmcast && pskb2) {
+                                       if (bmcast && pskb2)
                                                pkt = pskb2;
-                                               DBG_COUNTER(padapter->rx_logs.os_indicate_ap_mcast);
-                                       } else {
-                                               DBG_COUNTER(padapter->rx_logs.os_indicate_ap_forward);
+                                       else
                                                return;
-                                       }
                                }
                        } else {
                                /*  to APself */
                                /* DBG_871X("to APSelf\n"); */
-                               DBG_COUNTER(padapter->rx_logs.os_indicate_ap_self);
                        }
                }
 
@@ -153,10 +149,6 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt
 #endif /* CONFIG_TCP_CSUM_OFFLOAD_RX */
 
                ret = rtw_netif_rx(padapter->pnetdev, pkt);
-               if (ret == NET_RX_SUCCESS)
-                       DBG_COUNTER(padapter->rx_logs.os_netif_ok);
-               else
-                       DBG_COUNTER(padapter->rx_logs.os_netif_err);
        }
 }
 
@@ -246,8 +238,6 @@ int rtw_recv_indicatepkt(struct adapter *padapter, union recv_frame *precv_frame
        _pkt *skb;
        struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
 
-       DBG_COUNTER(padapter->rx_logs.os_indicate);
-
        precvpriv = &(padapter->recvpriv);
        pfree_recv_queue = &(precvpriv->free_recv_queue);
 
@@ -293,7 +283,6 @@ _recv_indicatepkt_drop:
        /* enqueue back to free_recv_queue */
        rtw_free_recvframe(precv_frame, pfree_recv_queue);
 
-       DBG_COUNTER(padapter->rx_logs.os_indicate_err);
        return _FAIL;
 }