staging: r8188eu: always update status before WPS blinking
authorMartin Kaiser <martin@kaiser.cx>
Mon, 5 Sep 2022 20:01:43 +0000 (22:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 Sep 2022 07:52:08 +0000 (09:52 +0200)
Always update the status variables in rtw_led_control when we start WPS
blinking. The code is easier to understand without the if conditions.

Tested-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220905200146.82259-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_led.c

index 72fef3ac8c0e5f07c7b186520f417e0706f3a544..4841bb2898ba76b4e91b5e7fa16ec6a79b00f3d3 100644 (file)
@@ -313,18 +313,11 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction)
                        return;
 
                cancel_delayed_work(&pLed->blink_work);
-               if (pLed->bLedNoLinkBlinkInProgress)
-                       pLed->bLedNoLinkBlinkInProgress = false;
-
-               if (pLed->bLedLinkBlinkInProgress)
-                       pLed->bLedLinkBlinkInProgress = false;
-
-               if (pLed->bLedBlinkInProgress)
-                       pLed->bLedBlinkInProgress = false;
-
-               if (pLed->bLedScanBlinkInProgress)
-                       pLed->bLedScanBlinkInProgress = false;
 
+               pLed->bLedNoLinkBlinkInProgress = false;
+               pLed->bLedLinkBlinkInProgress = false;
+               pLed->bLedBlinkInProgress = false;
+               pLed->bLedScanBlinkInProgress = false;
                pLed->bLedWPSBlinkInProgress = true;
                pLed->CurrLedState = LED_BLINK_WPS;
                if (pLed->bLedOn)