RDMA/irdma: Make irdma_uk_cq_init() return a void

The function irdma_uk_cq_init always returns 0, so make it void and delete
all the return value checks.

Link: https://lore.kernel.org/r/20211019153717.3836-1-yanjun.zhu@linux.dev
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Reviewed-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

diff --git a/drivers/infiniband/hw/irdma/ctrl.c b/drivers/infiniband/hw/irdma/ctrl.c
index 729fa8a3f6f806c54f6c5826e7e56dbb8c1fd93a..7264f8c2f7d5792820033742f511799f6e9124a0 100644 (file)
--- a/drivers/infiniband/hw/irdma/ctrl.c
+++ b/drivers/infiniband/hw/irdma/ctrl.c
@@ -2463,7 +2463,6 @@ static inline void irdma_sc_cq_ack(struct irdma_sc_cq *cq)
 enum irdma_status_code irdma_sc_cq_init(struct irdma_sc_cq *cq,
                                        struct irdma_cq_init_info *info)
 {
-       enum irdma_status_code ret_code;
        u32 pble_obj_cnt;
 
        pble_obj_cnt = info->dev->hmc_info->hmc_obj[IRDMA_HMC_IW_PBLE].cnt;
@@ -2475,9 +2474,7 @@ enum irdma_status_code irdma_sc_cq_init(struct irdma_sc_cq *cq,
        cq->ceq_id = info->ceq_id;
        info->cq_uk_init_info.cqe_alloc_db = cq->dev->cq_arm_db;
        info->cq_uk_init_info.cq_ack_db = cq->dev->cq_ack_db;
-       ret_code = irdma_uk_cq_init(&cq->cq_uk, &info->cq_uk_init_info);
-       if (ret_code)
-               return ret_code;
+       irdma_uk_cq_init(&cq->cq_uk, &info->cq_uk_init_info);
 
        cq->virtual_map = info->virtual_map;
        cq->pbl_chunk_size = info->pbl_chunk_size;

diff --git a/drivers/infiniband/hw/irdma/uk.c b/drivers/infiniband/hw/irdma/uk.c
index ebcd93bb9e9d7f8bcbddff51bfbb3bf33010eecf..cc578974ad0e02f76faf927d90408f039b3d4932 100644 (file)
--- a/drivers/infiniband/hw/irdma/uk.c
+++ b/drivers/infiniband/hw/irdma/uk.c
@@ -1446,8 +1446,8 @@ enum irdma_status_code irdma_uk_qp_init(struct irdma_qp_uk *qp,
  * @cq: hw cq
  * @info: hw cq initialization info
  */
-enum irdma_status_code irdma_uk_cq_init(struct irdma_cq_uk *cq,
-                                       struct irdma_cq_uk_init_info *info)
+void irdma_uk_cq_init(struct irdma_cq_uk *cq,
+                     struct irdma_cq_uk_init_info *info)
 {
        cq->cq_base = info->cq_base;
        cq->cq_id = info->cq_id;
@@ -1458,8 +1458,6 @@ enum irdma_status_code irdma_uk_cq_init(struct irdma_cq_uk *cq,
        cq->avoid_mem_cflct = info->avoid_mem_cflct;
        IRDMA_RING_INIT(cq->cq_ring, cq->cq_size);
        cq->polarity = 1;
-
-       return 0;
 }
 
 /**

diff --git a/drivers/infiniband/hw/irdma/user.h b/drivers/infiniband/hw/irdma/user.h
index 31d5e4e3f4423df7fa0b25502c052be311e5970d..66e00660fbaab6609870269ee67bced5dca3fd4a 100644 (file)
--- a/drivers/infiniband/hw/irdma/user.h
+++ b/drivers/infiniband/hw/irdma/user.h
@@ -316,8 +316,8 @@ void irdma_uk_cq_request_notification(struct irdma_cq_uk *cq,
                                      enum irdma_cmpl_notify cq_notify);
 void irdma_uk_cq_resize(struct irdma_cq_uk *cq, void *cq_base, int size);
 void irdma_uk_cq_set_resized_cnt(struct irdma_cq_uk *qp, u16 cnt);
-enum irdma_status_code irdma_uk_cq_init(struct irdma_cq_uk *cq,
-                                       struct irdma_cq_uk_init_info *info);
+void irdma_uk_cq_init(struct irdma_cq_uk *cq,
+                     struct irdma_cq_uk_init_info *info);
 enum irdma_status_code irdma_uk_qp_init(struct irdma_qp_uk *qp,
                                        struct irdma_qp_uk_init_info *info);
 struct irdma_sq_uk_wr_trk_info {