mtd: spinand: core: Properly fill the OOB area.

The comment in spinand_write_to_cache_op() says that
spinand_ondie_ecc_prepare_io_req() should 0xff fill the OOB
area but it doesn't.

This causes the OOB area to get filled with zeros
and anytime the first page in a block the bad block marker
is cleared and it becomes a bad block on the next boot.

This was observed on Longsys FORSEE branded parts and
might be specific to these parts.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20210617110842.2358461-1-daniel@0x0f.com

diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
index 4af32cfcbd96f708107572231e9bbece1f805428..2c8685f1f2fa7ff5485216130b0163fbdcce0c7a 100644 (file)
--- a/drivers/mtd/nand/spi/core.c
+++ b/drivers/mtd/nand/spi/core.c
@@ -288,6 +288,8 @@ static int spinand_ondie_ecc_prepare_io_req(struct nand_device *nand,
        struct spinand_device *spinand = nand_to_spinand(nand);
        bool enable = (req->mode != MTD_OPS_RAW);
 
+       memset(spinand->oobbuf, 0xff, nanddev_per_page_oobsize(nand));
+
        /* Only enable or disable the engine */
        return spinand_ecc_enable(spinand, enable);
 }