scsi: target: iscsi: Fix inconsistent debug message
authorHou Pu <houpu@bytedance.com>
Thu, 16 Jul 2020 10:02:12 +0000 (06:02 -0400)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 29 Jul 2020 02:15:31 +0000 (22:15 -0400)
Commit 25cdda95fda7 ("iscsi-target: Fix initial login PDU asynchronous
socket close OOPs") changed the return value of
__iscsi_target_sk_check_close(). However, pr_debug is still printing FALSE
when returning TRUE which is a little confusing.

Link: https://lore.kernel.org/r/20200716100212.4237-3-houpu@bytedance.com
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Hou Pu <houpu@bytedance.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/iscsi/iscsi_target_nego.c

index 43154fdba9910c7cb9c7d5d7190aa71a3b1efdb0..f88a52fec88952c74515f4ad4beaedbec2252cd6 100644 (file)
@@ -481,7 +481,7 @@ static bool __iscsi_target_sk_check_close(struct sock *sk)
 {
        if (sk->sk_state == TCP_CLOSE_WAIT || sk->sk_state == TCP_CLOSE) {
                pr_debug("__iscsi_target_sk_check_close: TCP_CLOSE_WAIT|TCP_CLOSE,"
-                       "returning FALSE\n");
+                       "returning TRUE\n");
                return true;
        }
        return false;