habanalabs: return correct error code on MMU mapping failure
authorOmer Shpigelman <oshpigelman@habana.ai>
Thu, 28 Feb 2019 08:46:18 +0000 (10:46 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Feb 2019 12:06:09 +0000 (13:06 +0100)
This patch fix a bug where EINVAL was returned instead of -EINVAL.

Signed-off-by: Omer Shpigelman <oshpigelman@habana.ai>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/habanalabs/mmu.c

index a7187f9a59482741ba55790e8df6de99b3d9ed31..ce404e6cc9a9b9c861d2019fa8b083da91f4e743 100644 (file)
@@ -710,7 +710,7 @@ static int _hl_mmu_map(struct hl_ctx *ctx, u64 virt_addr, u64 phys_addr,
                        dev_err(hdev->dev,
                                "DRAM: mapping already exists for virt_addr 0x%llx\n",
                                        virt_addr);
-                       rc = EINVAL;
+                       rc = -EINVAL;
                        goto err;
                }
 
@@ -744,7 +744,7 @@ static int _hl_mmu_map(struct hl_ctx *ctx, u64 virt_addr, u64 phys_addr,
                                                        hop4_pte_addr),
                                                        hop4_pte_addr);
 
-               rc = EINVAL;
+               rc = -EINVAL;
                goto err;
        }