powerpc/xics: fix refcount leak in icp_opal_init()
authorLv Ruyi <lv.ruyi@zte.com.cn>
Sat, 2 Apr 2022 01:34:19 +0000 (01:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:22:43 +0000 (10:22 +0200)
[ Upstream commit 5dd9e27ea4a39f7edd4bf81e9e70208e7ac0b7c9 ]

The of_find_compatible_node() function returns a node pointer with
refcount incremented, use of_node_put() on it when done.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220402013419.2410298-1-lv.ruyi@zte.com.cn
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/powerpc/sysdev/xics/icp-opal.c

index 675d708863d57540a8d00c2181e4f5f83cb4ca84..db0452e7c3515cc7383c376bd1a40e446a4c3e14 100644 (file)
@@ -196,6 +196,7 @@ int icp_opal_init(void)
 
        printk("XICS: Using OPAL ICP fallbacks\n");
 
+       of_node_put(np);
        return 0;
 }