i40e: Add helper for VF inited state check with timeout

Move the check for VF inited state (with optional up-to 300ms
timeout to separate helper i40e_check_vf_init_timeout() that
will be used in the following commit.

Tested-by: Ma Yuying <yuma@redhat.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index be59ba3774e1585acd548e7c54356a2e714b5501..b203465357afbe29bb29d00b364907c90a367e8c 100644 (file)
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -4304,6 +4304,38 @@ err_out:
        return ret;
 }
 
+/**
+ * i40e_check_vf_init_timeout
+ * @vf: the virtual function
+ *
+ * Check that the VF's initialization was successfully done and if not
+ * wait up to 300ms for its finish.
+ *
+ * Returns true when VF is initialized, false on timeout
+ **/
+static bool i40e_check_vf_init_timeout(struct i40e_vf *vf)
+{
+       int i;
+
+       /* When the VF is resetting wait until it is done.
+        * It can take up to 200 milliseconds, but wait for
+        * up to 300 milliseconds to be safe.
+        */
+       for (i = 0; i < 15; i++) {
+               if (test_bit(I40E_VF_STATE_INIT, &vf->vf_states))
+                       return true;
+               msleep(20);
+       }
+
+       if (!test_bit(I40E_VF_STATE_INIT, &vf->vf_states)) {
+               dev_err(&vf->pf->pdev->dev,
+                       "VF %d still in reset. Try again.\n", vf->vf_id);
+               return false;
+       }
+
+       return true;
+}
+
 /**
  * i40e_ndo_set_vf_mac
  * @netdev: network interface device structure
@@ -4322,7 +4354,6 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)
        int ret = 0;
        struct hlist_node *h;
        int bkt;
-       u8 i;
 
        if (test_and_set_bit(__I40E_VIRTCHNL_OP_PENDING, pf->state)) {
                dev_warn(&pf->pdev->dev, "Unable to configure VFs, other operation is pending.\n");
@@ -4335,21 +4366,7 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)
                goto error_param;
 
        vf = &pf->vf[vf_id];
-
-       /* When the VF is resetting wait until it is done.
-        * It can take up to 200 milliseconds,
-        * but wait for up to 300 milliseconds to be safe.
-        * Acquire the VSI pointer only after the VF has been
-        * properly initialized.
-        */
-       for (i = 0; i < 15; i++) {
-               if (test_bit(I40E_VF_STATE_INIT, &vf->vf_states))
-                       break;
-               msleep(20);
-       }
-       if (!test_bit(I40E_VF_STATE_INIT, &vf->vf_states)) {
-               dev_err(&pf->pdev->dev, "VF %d still in reset. Try again.\n",
-                       vf_id);
+       if (!i40e_check_vf_init_timeout(vf)) {
                ret = -EAGAIN;
                goto error_param;
        }