media: bdisp: Fix a possible sleep-in-atomic bug in bdisp_hw_save_request

The driver may sleep under a spinlock.
The function call path is:
bdisp_device_run (acquire the spinlock)
  bdisp_hw_update
    bdisp_hw_save_request
      devm_kzalloc(GFP_KERNEL) --> may sleep

To fix it, GFP_KERNEL is replaced with GFP_ATOMIC.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Fabien Dessenne <fabien.dessenne@st.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c b/drivers/media/platform/sti/bdisp/bdisp-hw.c
index e7836b307d218b11f617c24de91122abc2fb5033..a5eb592e12c048c0ab5fb5b4bf30f86f0667ee36 100644 (file)
--- a/drivers/media/platform/sti/bdisp/bdisp-hw.c
+++ b/drivers/media/platform/sti/bdisp/bdisp-hw.c
@@ -1064,7 +1064,7 @@ static void bdisp_hw_save_request(struct bdisp_ctx *ctx)
                if (!copy_node[i]) {
                        copy_node[i] = devm_kzalloc(ctx->bdisp_dev->dev,
                                                    sizeof(*copy_node[i]),
-                                                   GFP_KERNEL);
+                                                   GFP_ATOMIC);
                        if (!copy_node[i])
                                return;
                }