serial: 8250_dma: Convert to use uart_xmit_advance()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 9 Sep 2022 09:11:02 +0000 (12:11 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Sep 2022 07:27:41 +0000 (09:27 +0200)
uart_xmit_advance() provides a common way on how to advance
the Tx queue. Use it for the sake of unification and robustness.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220909091102.58941-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_dma.c

index d99020fd3427382342ce83c83b03db6be8a09bb5..b85c82616e8cbb8d7853dfd5c0fef202299803b8 100644 (file)
@@ -26,9 +26,7 @@ static void __dma_tx_complete(void *param)
 
        dma->tx_running = 0;
 
-       xmit->tail += dma->tx_size;
-       xmit->tail &= UART_XMIT_SIZE - 1;
-       p->port.icount.tx += dma->tx_size;
+       uart_xmit_advance(&p->port, dma->tx_size);
 
        if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
                uart_write_wakeup(&p->port);