scsi: lpfc: Eliminate unnecessary relocking in lpfc_check_nlp_post_devloss()

In lpfc_check_nlp_post_devloss(), retaking of the ndlp lock in the if
statement is useless because the very next line unlocks. Simply return to
avoid relocking.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20231031191224.150862-5-justintee8345@gmail.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
index 7ef9841f0728885206e5f0860a5b7fcbcb5a7b24..f80bbc315f4caa57ea7f36ca3358c6cb68c01cda 100644 (file)
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c
+++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
@@ -411,7 +411,7 @@ lpfc_check_nlp_post_devloss(struct lpfc_vport *vport,
                                 "port_state = x%x\n",
                                 ndlp->nlp_DID, kref_read(&ndlp->kref), ndlp,
                                 ndlp->nlp_flag, vport->port_state);
-               spin_lock_irqsave(&ndlp->lock, iflags);
+               return;
        }
        spin_unlock_irqrestore(&ndlp->lock, iflags);
 }