eeprom: idt_89hpesx: Restore printing the unsupported fwnode name
authorAndy Shevchenko <andy.shevchenko@gmail.com>
Mon, 7 Jun 2021 22:17:56 +0000 (01:17 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jun 2021 16:39:40 +0000 (18:39 +0200)
When iterating over child firmware nodes restore printing the name of ones
that are not supported.

While at it, refactor loop body to clearly show that we stop at the first match.

Fixes: db15d73e5f0e ("eeprom: idt_89hpesx: Support both ACPI and OF probing")
Cc: Huy Duong <qhuyduong@hotmail.com>
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20210607221757.81465-2-andy.shevchenko@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/eeprom/idt_89hpesx.c

index 45a61a1f9e98ab465d565d475eeb82cc6931447c..3e4a594c110b3e93d73945d03c0d2eadafa6344f 100644 (file)
@@ -1126,11 +1126,10 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev)
 
        device_for_each_child_node(dev, fwnode) {
                ee_id = idt_ee_match_id(fwnode);
-               if (!ee_id) {
-                       dev_warn(dev, "Skip unsupported EEPROM device");
-                       continue;
-               } else
+               if (ee_id)
                        break;
+
+               dev_warn(dev, "Skip unsupported EEPROM device %pfw\n", fwnode);
        }
 
        /* If there is no fwnode EEPROM device, then set zero size */