efi/capsule-loader: Drop superfluous assignment
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Sun, 23 Feb 2020 20:54:35 +0000 (21:54 +0100)
committerArd Biesheuvel <ardb@kernel.org>
Sun, 23 Feb 2020 20:58:31 +0000 (21:58 +0100)
In efi_capsule_write() the value 0 assigned to ret is never used.

Identified with cppcheck.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Link: https://lore.kernel.org/r/20200223205435.114915-1-xypron.glpk@gmx.de
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
drivers/firmware/efi/capsule-loader.c

index d3067cbd51143fade89c68ef6ca15346622121b0..4dde8edd53b62225a54e2fe0da5df2f30bde050f 100644 (file)
@@ -168,7 +168,7 @@ static ssize_t efi_capsule_submit_update(struct capsule_info *cap_info)
 static ssize_t efi_capsule_write(struct file *file, const char __user *buff,
                                 size_t count, loff_t *offp)
 {
-       int ret = 0;
+       int ret;
        struct capsule_info *cap_info = file->private_data;
        struct page *page;
        void *kbuff = NULL;