projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
98cc0e6
)
scsi: libfc: Call scsi_done() directly
author
Bart Van Assche
<bvanassche@acm.org>
Thu, 7 Oct 2021 20:28:38 +0000
(13:28 -0700)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:28:48 +0000
(21:28 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.
Link:
https://lore.kernel.org/r/20211007202923.2174984-44-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libfc/fc_fcp.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/libfc/fc_fcp.c
b/drivers/scsi/libfc/fc_fcp.c
index 509eacd7893d7518b6a83737b6c524d79d51f199..871b11edb586f84c293a9b55c8c6750f1fba6520 100644
(file)
--- a/
drivers/scsi/libfc/fc_fcp.c
+++ b/
drivers/scsi/libfc/fc_fcp.c
@@
-1870,7
+1870,7
@@
int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd)
rval = fc_remote_port_chkready(rport);
if (rval) {
sc_cmd->result = rval;
- sc
_cmd->sc
si_done(sc_cmd);
+ scsi_done(sc_cmd);
return 0;
}
@@
-1880,7
+1880,7
@@
int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd)
* online
*/
sc_cmd->result = DID_IMM_RETRY << 16;
- sc
_cmd->sc
si_done(sc_cmd);
+ scsi_done(sc_cmd);
goto out;
}
@@
-2087,7
+2087,7
@@
static void fc_io_compl(struct fc_fcp_pkt *fsp)
list_del(&fsp->list);
sc_cmd->SCp.ptr = NULL;
spin_unlock_irqrestore(&si->scsi_queue_lock, flags);
- sc
_cmd->sc
si_done(sc_cmd);
+ scsi_done(sc_cmd);
/* release ref from initial allocation in queue command */
fc_fcp_pkt_release(fsp);