ASoC: SOF: intel: atom: No need to do a DSP dump in atom_run()
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Wed, 6 Oct 2021 11:06:32 +0000 (14:06 +0300)
committerMark Brown <broonie@kernel.org>
Thu, 7 Oct 2021 14:45:27 +0000 (15:45 +0100)
The core already prints a dump if the DSP failed to start in
snd_sof_run_firmware(), there is no need to print it locally as well.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211006110645.26679-7-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/atom.c

index d8804efede5e91fa579f66976230aad0837bc248..74c630bb9847185f952a16ee72c0908768dec765 100644 (file)
@@ -283,11 +283,8 @@ int atom_run(struct snd_sof_dev *sdev)
                        break;
                msleep(100);
        }
-       if (tries < 0) {
-               dev_err(sdev->dev, "error:  unable to run DSP firmware\n");
-               atom_dump(sdev, SOF_DBG_DUMP_REGS | SOF_DBG_DUMP_MBOX);
+       if (tries < 0)
                return -ENODEV;
-       }
 
        /* return init core mask */
        return 1;