cpufreq: Change default transition delay to 2ms
authorQais Yousef <qyousef@layalina.io>
Mon, 5 Feb 2024 02:25:00 +0000 (02:25 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 12 Feb 2024 15:50:30 +0000 (16:50 +0100)
10ms is too high for today's hardware, even low end ones. This default
end up being used a lot on Arm machines at least. Pine64, mac mini and
pixel 6 all end up with 10ms rate_limit_us when using schedutil, and
it's too high for all of them.

Change the default to 2ms which should be 'pessimistic' enough for worst
case scenario, but not too high for platforms with fast DVFS hardware.

Signed-off-by: Qais Yousef <qyousef@layalina.io>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cpufreq.c

index 44db4f59c4cc6cc839b062b8ab84efa6bad5b729..66cef33c4ec7b4595c80d978c40808833ef8fb86 100644 (file)
@@ -582,11 +582,11 @@ unsigned int cpufreq_policy_transition_delay_us(struct cpufreq_policy *policy)
                 * for platforms where transition_latency is in milliseconds, it
                 * ends up giving unrealistic values.
                 *
-                * Cap the default transition delay to 10 ms, which seems to be
+                * Cap the default transition delay to 2 ms, which seems to be
                 * a reasonable amount of time after which we should reevaluate
                 * the frequency.
                 */
-               return min(latency * LATENCY_MULTIPLIER, (unsigned int)10000);
+               return min(latency * LATENCY_MULTIPLIER, (unsigned int)(2 * MSEC_PER_SEC));
        }
 
        return LATENCY_MULTIPLIER;