serial: max310x: use dev_err_probe() instead of dev_err()

Replace dev_err() with dev_err_probe().

This helps in simplifing code and standardizing the error output.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/20240118152213.2644269-12-hugo@hugovil.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
index 048ae432ba4847a060059fe85db9e18eeaf377e8..701bf54e4084393cf1f71357f56c863f7cbbd520 100644 (file)
--- a/drivers/tty/serial/max310x.c
+++ b/drivers/tty/serial/max310x.c
@@ -1275,10 +1275,9 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty
 
        /* Alloc port structure */
        s = devm_kzalloc(dev, struct_size(s, p, devtype->nr), GFP_KERNEL);
-       if (!s) {
-               dev_err(dev, "Error allocating port structure\n");
-               return -ENOMEM;
-       }
+       if (!s)
+               return dev_err_probe(dev, -ENOMEM,
+                                    "Error allocating port structure\n");
 
        /* Always ask for fixed clock rate from a property. */
        device_property_read_u32(dev, "clock-frequency", &uartclk);
@@ -1299,8 +1298,7 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty
        if (freq == 0)
                freq = uartclk;
        if (freq == 0) {
-               dev_err(dev, "Cannot get clock rate\n");
-               ret = -EINVAL;
+               ret = dev_err_probe(dev, -EINVAL, "Cannot get clock rate\n");
                goto out_clk;
        }