fpga: dfl: pci: reduce the scope of variable 'ret'
authorXu Yilun <yilun.xu@intel.com>
Mon, 13 Jul 2020 06:10:02 +0000 (14:10 +0800)
committerMoritz Fischer <mdf@kernel.org>
Tue, 14 Jul 2020 05:11:17 +0000 (22:11 -0700)
This is to fix lkp cppcheck warnings:

 drivers/fpga/dfl-pci.c:230:6: warning: The scope of the variable 'ret' can be reduced. [variableScope]
    int ret = 0;
        ^

 drivers/fpga/dfl-pci.c:230:10: warning: Variable 'ret' is assigned a value that is never used. [unreadVariable]
    int ret = 0;
            ^

Fixes: 3c2760b78f90 ("fpga: dfl: pci: fix return value of cci_pci_sriov_configure")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
Acked-by: Wu Hao <hao.wu@intel.com>
Reviewed-by: Tom Rix <trix@redhat.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
drivers/fpga/dfl-pci.c

index 538755062ab7ca7d8fee6911ca2af02a8afc7a37..a78c409bf2c4490598c3a8838b37d6c45bb3348e 100644 (file)
@@ -227,7 +227,6 @@ static int cci_pci_sriov_configure(struct pci_dev *pcidev, int num_vfs)
 {
        struct cci_drvdata *drvdata = pci_get_drvdata(pcidev);
        struct dfl_fpga_cdev *cdev = drvdata->cdev;
-       int ret = 0;
 
        if (!num_vfs) {
                /*
@@ -239,6 +238,8 @@ static int cci_pci_sriov_configure(struct pci_dev *pcidev, int num_vfs)
                dfl_fpga_cdev_config_ports_pf(cdev);
 
        } else {
+               int ret;
+
                /*
                 * before enable SRIOV, put released ports into VF access mode
                 * first of all.