media: i2c: hi846: check return value of regulator_bulk_disable()

regulator_bulk_disable can fail and thus suspend() can. Handle that error
gracefully.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c
index 48909faeced4663cd169276abd33eb5df1ac88cd..47fa0324f7fbe824a414681e46574d9210edb5ee 100644 (file)
--- a/drivers/media/i2c/hi846.c
+++ b/drivers/media/i2c/hi846.c
@@ -1656,7 +1656,7 @@ err_reg:
        return ret;
 }
 
-static void hi846_power_off(struct hi846 *hi846)
+static int hi846_power_off(struct hi846 *hi846)
 {
        if (hi846->rst_gpio)
                gpiod_set_value_cansleep(hi846->rst_gpio, 1);
@@ -1665,7 +1665,7 @@ static void hi846_power_off(struct hi846 *hi846)
                gpiod_set_value_cansleep(hi846->shutdown_gpio, 1);
 
        clk_disable_unprepare(hi846->clock);
-       regulator_bulk_disable(HI846_NUM_SUPPLIES, hi846->supplies);
+       return regulator_bulk_disable(HI846_NUM_SUPPLIES, hi846->supplies);
 }
 
 static int __maybe_unused hi846_suspend(struct device *dev)
@@ -1677,9 +1677,7 @@ static int __maybe_unused hi846_suspend(struct device *dev)
        if (hi846->streaming)
                hi846_stop_streaming(hi846);
 
-       hi846_power_off(hi846);
-
-       return 0;
+       return hi846_power_off(hi846);
 }
 
 static int __maybe_unused hi846_resume(struct device *dev)