drm/xe: Stop passing user flag to xe_bo_create_user()
authorLucas De Marchi <lucas.demarchi@intel.com>
Fri, 22 Mar 2024 14:27:01 +0000 (07:27 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Tue, 2 Apr 2024 17:32:54 +0000 (10:32 -0700)
It's quite redundant to pass XE_BO_CREATE_USER_BIT to
xe_bo_create_user() since the only difference of that function is to
force that flag. Stop passing the flag in the few cases that were
explicitly doing so.

Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240322142702.186529-2-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/tests/xe_dma_buf.c
drivers/gpu/drm/xe/xe_bo.c

index 9f6d571d7fa9cb794fb86fec1f326ed3adfb85b9..2a86dc4eb8af098c0e2e2d7dbcecf2cc36f78afd 100644 (file)
@@ -125,7 +125,7 @@ static void xe_test_dmabuf_import_same_driver(struct xe_device *xe)
 
        kunit_info(test, "running %s\n", __func__);
        bo = xe_bo_create_user(xe, NULL, NULL, size, DRM_XE_GEM_CPU_CACHING_WC,
-                              ttm_bo_type_device, XE_BO_CREATE_USER_BIT | params->mem_mask);
+                              ttm_bo_type_device, params->mem_mask);
        if (IS_ERR(bo)) {
                KUNIT_FAIL(test, "xe_bo_create() failed with err=%ld\n",
                           PTR_ERR(bo));
index 9298546909b5231a5423c7c9d29a370095025523..883f68a527d87fa9c8f80d199a305644f273c5bc 100644 (file)
@@ -2279,7 +2279,7 @@ int xe_bo_dumb_create(struct drm_file *file_priv,
                               DRM_XE_GEM_CPU_CACHING_WC,
                               ttm_bo_type_device,
                               XE_BO_CREATE_VRAM_IF_DGFX(xe_device_get_root_tile(xe)) |
-                              XE_BO_CREATE_USER_BIT | XE_BO_SCANOUT_BIT |
+                              XE_BO_SCANOUT_BIT |
                               XE_BO_NEEDS_CPU_ACCESS);
        if (IS_ERR(bo))
                return PTR_ERR(bo);