staging: rtl8723bs: os_dep: Remove true and false comparison
authorMamta Shukla <mamtashukla555@gmail.com>
Thu, 11 Oct 2018 17:44:42 +0000 (23:14 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 Oct 2018 18:20:06 +0000 (20:20 +0200)
Remove comparison to true and false in if statement.
Issue found with checkpatch.pl
CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error prone

Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

index c38298d960fffc18b3cca843ef1881de839a4629..48a1560e577b7d009dbfa7678af38c7985e39266 100644 (file)
@@ -209,9 +209,9 @@ static char *translate_scan(struct adapter *padapter,
                i++;
        }
 
-       if (vht_cap == true) {
+       if (vht_cap) {
                max_rate = vht_data_rate;
-       } else if (ht_cap == true) {
+       } else if (ht_cap) {
                if (mcs_rate&0x8000) { /* MCS15 */
                        max_rate = (bw_40MHz) ? ((short_GI)?300:270):((short_GI)?144:130);
                } else if (mcs_rate&0x0080) { /* MCS7 */
@@ -862,7 +862,7 @@ static int rtw_wx_set_mode(struct net_device *dev, struct iw_request_info *a,
                goto exit;
        }
 
-       if (padapter->hw_init_completed ==false) {
+       if (!padapter->hw_init_completed) {
                ret = -EPERM;
                goto exit;
        }
@@ -1295,7 +1295,7 @@ static int rtw_wx_set_scan(struct net_device *dev, struct iw_request_info *a,
                goto exit;
        }
 
-       if (padapter->hw_init_completed ==false) {
+       if (!padapter->hw_init_completed ) {
                ret = -1;
                goto exit;
        }
@@ -1303,7 +1303,7 @@ static int rtw_wx_set_scan(struct net_device *dev, struct iw_request_info *a,
        /*  When Busy Traffic, driver do not site survey. So driver return success. */
        /*  wpa_supplicant will not issue SIOCSIWSCAN cmd again after scan timeout. */
        /*  modify by thomas 2011-02-22. */
-       if (pmlmepriv->LinkDetectInfo.bBusyTraffic == true) {
+       if (pmlmepriv->LinkDetectInfo.bBusyTraffic) {
                indicate_wx_scan_complete_event(padapter);
                goto exit;
        }
@@ -4229,7 +4229,7 @@ static int rtw_hostapd_ioctl(struct net_device *dev, struct iw_point *p)
        * so, we just check hw_init_completed
        */
 
-       if (padapter->hw_init_completed ==false) {
+       if (!padapter->hw_init_completed) {
                ret = -EPERM;
                goto out;
        }