power: supply: ab8500: Drop unnecessary NULL check after container_of
authorGuenter Roeck <linux@roeck-us.net>
Tue, 11 May 2021 20:37:11 +0000 (13:37 -0700)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Thu, 3 Jun 2021 16:50:45 +0000 (18:50 +0200)
The result of container_of() operations is never NULL unless the element
is the first element of the embedded structure, which is not the case here.
The NULL check is therefore unnecessary and misleading. Remove it.

This change was made automatically with the following Coccinelle script.

@@
type t;
identifier v;
statement s;
@@

<+...
(
  t v = container_of(...);
|
  v = container_of(...);
)
  ...
  when != v
- if (\( !v \| v == NULL \) ) s
...+>

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/ab8500_charger.c

index e6f23ae05f95e2d18753146a69adb905551322f2..4a6bc4330c08b8878d1bb640fbbd38633d9be7ca 100644 (file)
@@ -3188,9 +3188,6 @@ static int ab8500_charger_usb_notifier_call(struct notifier_block *nb,
        enum ab8500_usb_state bm_usb_state;
        unsigned mA = *((unsigned *)power);
 
-       if (!di)
-               return NOTIFY_DONE;
-
        if (event != USB_EVENT_VBUS) {
                dev_dbg(di->dev, "not a standard host, returning\n");
                return NOTIFY_DONE;