Revert "arm64: Mitigate MTE issues with str{n}cmp()"
authorJoey Gouly <joey.gouly@arm.com>
Tue, 1 Mar 2022 10:14:35 +0000 (10:14 +0000)
committerWill Deacon <will@kernel.org>
Mon, 7 Mar 2022 21:57:02 +0000 (21:57 +0000)
This reverts commit 59a68d4138086c015ab8241c3267eec5550fbd44.

Now that the str{n}cmp functions have been updated to handle MTE
properly, the workaround to use the generic functions is no longer
needed.

Signed-off-by: Joey Gouly <joey.gouly@arm.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Link: https://lore.kernel.org/r/20220301101435.19327-4-joey.gouly@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/include/asm/assembler.h
arch/arm64/include/asm/string.h
arch/arm64/lib/strcmp.S
arch/arm64/lib/strncmp.S

index e8bd0af0141c36164170701ca598d8ff6610288b..8df412178efbd7ee350f3d34c37d9986f90e537d 100644 (file)
@@ -535,11 +535,6 @@ alternative_endif
 #define EXPORT_SYMBOL_NOKASAN(name)    EXPORT_SYMBOL(name)
 #endif
 
-#ifdef CONFIG_KASAN_HW_TAGS
-#define EXPORT_SYMBOL_NOHWKASAN(name)
-#else
-#define EXPORT_SYMBOL_NOHWKASAN(name)  EXPORT_SYMBOL_NOKASAN(name)
-#endif
        /*
         * Emit a 64-bit absolute little endian symbol reference in a way that
         * ensures that it will be resolved at build time, even when building a
index 95f7686b728d7e5689f46ce6ae37fe7724779be2..3a3264ff47b9709df741eaece1c8eae995a5ffb3 100644 (file)
@@ -12,13 +12,11 @@ extern char *strrchr(const char *, int c);
 #define __HAVE_ARCH_STRCHR
 extern char *strchr(const char *, int c);
 
-#ifndef CONFIG_KASAN_HW_TAGS
 #define __HAVE_ARCH_STRCMP
 extern int strcmp(const char *, const char *);
 
 #define __HAVE_ARCH_STRNCMP
 extern int strncmp(const char *, const char *, __kernel_size_t);
-#endif
 
 #define __HAVE_ARCH_STRLEN
 extern __kernel_size_t strlen(const char *);
index 758de77afd2f70ccfaf16b0805e066fc5d497926..e6815a3dd26561105bc1e46c9d47cc996ae40857 100644 (file)
@@ -187,4 +187,4 @@ L(done):
        ret
 
 SYM_FUNC_END_PI(strcmp)
-EXPORT_SYMBOL_NOHWKASAN(strcmp)
+EXPORT_SYMBOL_NOKASAN(strcmp)
index a4884b97e9a812a62078f74cfbf3ec488e446376..bc195cb866932bd3859d8988dd1afc331326f414 100644 (file)
@@ -306,4 +306,4 @@ L(ret0):
        mov     result, #0
        ret
 SYM_FUNC_END_PI(strncmp)
-EXPORT_SYMBOL_NOHWKASAN(strncmp)
+EXPORT_SYMBOL_NOKASAN(strncmp)