Revert "mei: vsc: Call wake_up() in the threaded IRQ handler"
authorSakari Ailus <sakari.ailus@linux.intel.com>
Wed, 3 Apr 2024 05:13:40 +0000 (13:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 Apr 2024 13:15:52 +0000 (15:15 +0200)
This reverts commit 058a38acba15fd8e7b262ec6e17c4204cb15f984.

It's not necessary to avoid a spinlock, a sleeping lock on PREEMPT_RT, in
an interrupt handler as the interrupt handler itself would be called in a
process context if PREEMPT_RT is enabled. So revert the patch.

Cc: stable@vger.kernel.org # for 6.8
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
Link: https://lore.kernel.org/r/20240403051341.3534650-1-wentong.wu@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/vsc-tp.c

index ecfb70cd057ca01eb33e544ef242ab1aee2cd25a..968a92a7425df36a6c5ee4bdfa16250ca7bd5d11 100644 (file)
@@ -419,6 +419,8 @@ static irqreturn_t vsc_tp_isr(int irq, void *data)
 
        atomic_inc(&tp->assert_cnt);
 
+       wake_up(&tp->xfer_wait);
+
        return IRQ_WAKE_THREAD;
 }
 
@@ -426,8 +428,6 @@ static irqreturn_t vsc_tp_thread_isr(int irq, void *data)
 {
        struct vsc_tp *tp = data;
 
-       wake_up(&tp->xfer_wait);
-
        if (tp->event_notify)
                tp->event_notify(tp->event_notify_context);