time/tick-broadcast: Remove RCU_NONIDLE() usage
authorPeter Zijlstra <peterz@infradead.org>
Thu, 12 Jan 2023 19:43:40 +0000 (20:43 +0100)
committerIngo Molnar <mingo@kernel.org>
Fri, 13 Jan 2023 10:48:16 +0000 (11:48 +0100)
No callers left that have already disabled RCU.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Tony Lindgren <tony@atomide.com>
Tested-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/20230112195540.927904612@infradead.org
kernel/time/tick-broadcast-hrtimer.c

index 797eb93103ad4d373d2fca50b4baeadf8da10e96..e28f9210f8a15ea62d73e416562f903a415765bf 100644 (file)
@@ -56,25 +56,20 @@ static int bc_set_next(ktime_t expires, struct clock_event_device *bc)
         * hrtimer callback function is currently running, then
         * hrtimer_start() cannot move it and the timer stays on the CPU on
         * which it is assigned at the moment.
+        */
+       hrtimer_start(&bctimer, expires, HRTIMER_MODE_ABS_PINNED_HARD);
+       /*
+        * The core tick broadcast mode expects bc->bound_on to be set
+        * correctly to prevent a CPU which has the broadcast hrtimer
+        * armed from going deep idle.
         *
-        * As this can be called from idle code, the hrtimer_start()
-        * invocation has to be wrapped with RCU_NONIDLE() as
-        * hrtimer_start() can call into tracing.
+        * As tick_broadcast_lock is held, nothing can change the cpu
+        * base which was just established in hrtimer_start() above. So
+        * the below access is safe even without holding the hrtimer
+        * base lock.
         */
-       RCU_NONIDLE( {
-               hrtimer_start(&bctimer, expires, HRTIMER_MODE_ABS_PINNED_HARD);
-               /*
-                * The core tick broadcast mode expects bc->bound_on to be set
-                * correctly to prevent a CPU which has the broadcast hrtimer
-                * armed from going deep idle.
-                *
-                * As tick_broadcast_lock is held, nothing can change the cpu
-                * base which was just established in hrtimer_start() above. So
-                * the below access is safe even without holding the hrtimer
-                * base lock.
-                */
-               bc->bound_on = bctimer.base->cpu_base->cpu;
-       } );
+       bc->bound_on = bctimer.base->cpu_base->cpu;
+
        return 0;
 }